ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeNavigationTest.ktmodified+12-3
Changes to packages/android/fixtures/native-navigation/NativeNavigationTest.kt
@@ -1628,7 +1628,16 @@ class NativeNavigationTest {
16281628 click(activity, "toggle-modal")
16291629 awaitText(activity, "modal-status", "modal shown")
16301630 click(activity, "toggle-nested-popup")
1631 val nestedPopup = awaitView(activity, "nested-popup")
1631 val popupDensity = activity.resources.displayMetrics.density
1632 // Modal content is retained while hidden. Wait for the opening
1633 // mutation and native layout before delivering an outside touch.
1634 val nestedPopup = awaitView(activity, "nested-popup") { view ->
1635 view.visibility == View.VISIBLE && view.alpha > 0.01f
1636 && kotlin.math.abs(view.left - 48 * popupDensity) <= 1f
1637 && kotlin.math.abs(view.top - 72 * popupDensity) <= 1f
1638 && kotlin.math.abs(view.width - 160 * popupDensity) <= 1f
1639 && kotlin.math.abs(view.height - 64 * popupDensity) <= 1f
1640 }
16321641 awaitText(activity, "nested-popup-content", "Nested popup")
16331642 // Popups are promoted beside the authored SafeAreaView. Route the
16341643 // native touch through their shared screen viewport, which owns
@@ -1657,9 +1666,9 @@ class NativeNavigationTest {
16571666 assertTrue("dismissed nested popup should be removed", nestedPopupRemoved || nestedPopup.visibility != View.VISIBLE)
16581667 assertEquals("dismissing a nested popup should retain its parent modal", View.VISIBLE, modal.visibility)
16591668 click(activity, "toggle-popup")
1660 val popupDensity = activity.resources.displayMetrics.density
16611669 val popup = awaitView(activity, "native-popup") { view ->
1662 kotlin.math.abs(view.left - 24 * popupDensity) <= 1f
1670 view.visibility == View.VISIBLE && view.alpha > 0.01f
1671 && kotlin.math.abs(view.left - 24 * popupDensity) <= 1f
16631672 && kotlin.math.abs(view.top - 36 * popupDensity) <= 1f
16641673 && kotlin.math.abs(view.width - 180 * popupDensity) <= 1f
16651674 && kotlin.math.abs(view.height - 72 * popupDensity) <= 1f