ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

scripts/verify-create-craft.tsmodified+6-1
Changes to scripts/verify-create-craft.ts
@@ -35,7 +35,12 @@ try {
3535 pkg.dependencies['craft-native'] = `file:${join(root, 'packages/typescript')}`
3636 writeFileSync(packagePath, `${JSON.stringify(pkg, null, 2)}\n`)
3737
38 run(['bun', 'install'], appDir)
38 // The local `craft-native` file dependency exposes the SDK checkout while
39 // the smoke app is installed. A regular install makes Bun traverse the
40 // SDK's development tool graph as well, which can ask the public registry
41 // for an unpublished compiler version. The generated app only exercises
42 // its runtime/build surface, so keep this check on production dependencies.
43 run(['bun', 'install', '--production'], appDir)
3944 run(['bun', 'run', 'build'], appDir)
4045 run(['bun', 'run', 'doctor'], appDir, {
4146 ...process.env,