ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeNavigationTest.ktmodified+2-1
Changes to packages/android/fixtures/native-navigation/NativeNavigationTest.kt
@@ -1616,7 +1616,8 @@ class NativeNavigationTest {
16161616 // native touch through their shared screen viewport, which owns
16171617 // outside-tap dismissal, rather than bypassing it through content.
16181618 val popupRoot = nestedPopup.parent as ViewGroup
1619 assertSame("nested popup must share the screen viewport", awaitView(activity, "root").parent, popupRoot)
1619 assertSame("nested popup must share its modal's screen viewport", modal.parent, popupRoot)
1620 assertSame("popup viewport must retain the authored content", awaitView(activity, "root"), find(popupRoot, "root"))
16201621 instrumentation.runOnMainSync {
16211622 val downTime = SystemClock.uptimeMillis()
16221623 val x = (popupRoot.width - 20).toFloat()