ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeNavigationTest.ktmodified+1-1
Changes to packages/android/fixtures/native-navigation/NativeNavigationTest.kt
@@ -1669,7 +1669,7 @@ class NativeNavigationTest {
16691669 val safeRoot = awaitView(activity, "root")
16701670 assertTrue(
16711671 "non-modal top should use the screenViewport origin, not a second safe-area offset",
1672 popup.top < safeRoot.top + safeRoot.paddingTop + 36,
1672 popup.top < safeRoot.top + safeRoot.paddingTop + 36 * popupDensity,
16731673 )
16741674 instrumentation.runOnMainSync {
16751675 val downTime = SystemClock.uptimeMillis()