ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeNavigationTest.ktmodified+6-1
Changes to packages/android/fixtures/native-navigation/NativeNavigationTest.kt
@@ -1612,7 +1612,11 @@ class NativeNavigationTest {
16121612 click(activity, "toggle-nested-popup")
16131613 val nestedPopup = awaitView(activity, "nested-popup")
16141614 awaitText(activity, "nested-popup-content", "Nested popup")
1615 val popupRoot = awaitView(activity, "root")
1615 // Popups are promoted beside the authored SafeAreaView. Route the
1616 // native touch through their shared screen viewport, which owns
1617 // outside-tap dismissal, rather than bypassing it through content.
1618 val popupRoot = nestedPopup.parent as ViewGroup
1619 assertSame("nested popup must share the screen viewport", awaitView(activity, "root").parent, popupRoot)
16161620 instrumentation.runOnMainSync {
16171621 val downTime = SystemClock.uptimeMillis()
16181622 val x = (popupRoot.width - 20).toFloat()
@@ -1636,6 +1640,7 @@ class NativeNavigationTest {
16361640 click(activity, "toggle-popup")
16371641 val popup = awaitView(activity, "native-popup")
16381642 awaitText(activity, "popup-content", "Popup content")
1643 assertSame("standalone popup must share the screen viewport", popupRoot, popup.parent)
16391644 val safeRoot = awaitView(activity, "root")
16401645 assertTrue(
16411646 "non-modal top should use the screenViewport origin, not a second safe-area offset",