ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeNavigationTest.ktmodifiedrenamed throughout+9-9
Changes to packages/android/fixtures/native-navigation/NativeNavigationTest.kt
@@ -1612,16 +1612,16 @@ class NativeNavigationTest {
16121612 click(activity, "toggle-nested-popup")
16131613 val nestedPopup = awaitView(activity, "nested-popup")
16141614 awaitText(activity, "nested-popup-content", "Nested popup")
1615 val root = awaitView(activity, "root")
1615 val popupRoot = awaitView(activity, "root")
16161616 instrumentation.runOnMainSync {
16171617 val downTime = SystemClock.uptimeMillis()
1618 val x = (root.width - 20).toFloat()
1619 val y = (root.height - 20).toFloat()
1618 val x = (popupRoot.width - 20).toFloat()
1619 val y = (popupRoot.height - 20).toFloat()
16201620 val down = MotionEvent.obtain(downTime, downTime, MotionEvent.ACTION_DOWN, x, y, 0)
1621 root.dispatchTouchEvent(down)
1621 popupRoot.dispatchTouchEvent(down)
16221622 down.recycle()
16231623 val up = MotionEvent.obtain(downTime, downTime + 32, MotionEvent.ACTION_UP, x, y, 0)
1624 root.dispatchTouchEvent(up)
1624 popupRoot.dispatchTouchEvent(up)
16251625 up.recycle()
16261626 }
16271627 awaitText(activity, "nested-popup-request-status", "nested popup requested backdrop")
@@ -1643,13 +1643,13 @@ class NativeNavigationTest {
16431643 )
16441644 instrumentation.runOnMainSync {
16451645 val downTime = SystemClock.uptimeMillis()
1646 val x = (root.width - 20).toFloat()
1647 val y = (root.height - 20).toFloat()
1646 val x = (popupRoot.width - 20).toFloat()
1647 val y = (popupRoot.height - 20).toFloat()
16481648 val down = MotionEvent.obtain(downTime, downTime, MotionEvent.ACTION_DOWN, x, y, 0)
1649 root.dispatchTouchEvent(down)
1649 popupRoot.dispatchTouchEvent(down)
16501650 down.recycle()
16511651 val up = MotionEvent.obtain(downTime, downTime + 32, MotionEvent.ACTION_UP, x, y, 0)
1652 root.dispatchTouchEvent(up)
1652 popupRoot.dispatchTouchEvent(up)
16531653 up.recycle()
16541654 }
16551655 awaitText(activity, "popup-request-status", "popup requested backdrop")