ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/mobile-e2e.ymlmodified+4-4
Changes to .github/workflows/mobile-e2e.yml
@@ -172,7 +172,7 @@ jobs:
172172 uses: actions/checkout@v6
173173 with:
174174 repository: stacksjs/stx
175 ref: 19797f29f1f3d1d2c27884de2f7e07366d1a7b5b
175 ref: 19797f29f132ff345ddd2648ca6701207a9fd2c2
176176 path: .stx-compiler
177177
178178 - name: Install stx compiler dependencies
@@ -294,7 +294,7 @@ jobs:
294294 uses: actions/checkout@v6
295295 with:
296296 repository: stacksjs/stx
297 ref: 19797f29f1f3d1d2c27884de2f7e07366d1a7b5b
297 ref: 19797f29f132ff345ddd2648ca6701207a9fd2c2
298298 path: .stx-compiler
299299
300300 - name: Install stx compiler dependencies
@@ -444,7 +444,7 @@ jobs:
444444 uses: actions/checkout@v6
445445 with:
446446 repository: stacksjs/stx
447 ref: 19797f29f1f3d1d2c27884de2f7e07366d1a7b5b
447 ref: 19797f29f132ff345ddd2648ca6701207a9fd2c2
448448 path: .stx-compiler
449449
450450 - name: Install Android stx compiler dependencies
@@ -651,7 +651,7 @@ jobs:
651651 - uses: actions/checkout@v6
652652 with:
653653 repository: stacksjs/stx
654 ref: 19797f29f1f3d1d2c27884de2f7e07366d1a7b5b
654 ref: 19797f29f132ff345ddd2648ca6701207a9fd2c2
655655 path: .stx-compiler
656656 - run: bun install --frozen-lockfile
657657 working-directory: .stx-compiler
docs/guides/native-stx.mdmodified+1-1
Changes to docs/guides/native-stx.md
@@ -73,7 +73,7 @@ renderer.
7373The maintained Mobile E2E workflow checks out one exact stx compiler commit for
7474both simulator hosts. Update the iOS and Android refs together; the workflow
7575contract test rejects compiler skew between them.
76The current pair is pinned to `19797f29f1f3d1d2c27884de2f7e07366d1a7b5b` (STX main),
76The current pair is pinned to `19797f29f132ff345ddd2648ca6701207a9fd2c2` (STX main),
7777which preserves authored reconciliation keys and explicit grid row tracks in
7878static and reactive native styles, and keeps template indentation out of native
7979leaf button labels. Touchable primitives preserve authored accessibility roles
scripts/release-workflow.test.tsmodified+1-1
Changes to scripts/release-workflow.test.ts
@@ -20,7 +20,7 @@ type Job = {
2020}
2121const release = Bun.YAML.parse(readFileSync(join(import.meta.dir, '../.github/workflows/release.yml'), 'utf8')) as { jobs: Record<string, Job> }
2222const artifactDownload = 'actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093'
23const stxCompilerCommit = '19797f29f1f3d1d2c27884de2f7e07366d1a7b5b'
23const stxCompilerCommit = '19797f29f132ff345ddd2648ca6701207a9fd2c2'
2424const needs = (job: Job) => typeof job.needs === 'string' ? [job.needs] : job.needs ?? []
2525const steps = (job: Job) => job.steps?.map(step => step.run ?? '').join('\n') ?? ''
2626