ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

scripts/native-renderer-contract.test.tsmodified+8-6
Changes to scripts/native-renderer-contract.test.ts
@@ -1885,12 +1885,14 @@ describe('native renderer component contract', () => {
18851885 })
18861886
18871887 it('documents optional native Health Services with capability checks and explicit failures', () => {
1888 expect(androidReadme).toContain('`enableHealthServices: true` to retain `ExerciseClient` in a foreground')
1889 expect(androidReadme).toContain('"enableHealthServices": false')
1890 expect(androidReadme).toContain('emit a typed `error` event and leave the Health Connect fallback untouched')
1891 expect(guide).toContain('`enableHealthServices: true`. Craft retains `ExerciseClient` in a foreground')
1892 expect(guide).toContain('checks device capabilities before starting')
1893 expect(guide).toContain('produce an `error` event rather than silently upgrading the fallback')
1888 const androidDocs = androidReadme.replace(/\s+/g, ' ')
1889 const guideDocs = guide.replace(/\s+/g, ' ')
1890 expect(androidDocs).toContain('`enableHealthServices: true` to retain `ExerciseClient` in a foreground')
1891 expect(androidDocs).toContain('"enableHealthServices": false')
1892 expect(androidDocs).toContain('emit a typed `error` event and leave the Health Connect fallback untouched')
1893 expect(guideDocs).toContain('`enableHealthServices: true`. Craft retains `ExerciseClient` in a foreground')
1894 expect(guideDocs).toContain('checks device capabilities before starting')
1895 expect(guideDocs).toContain('produce an `error` event rather than silently upgrading the fallback')
18941896 })
18951897
18961898 it('exposes screen-owned scrolling for mounted native scroll views', () => {