ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/ios/fixtures/native-navigation/NativeNavigationUITests.swiftmodified+12-0
Changes to packages/ios/fixtures/native-navigation/NativeNavigationUITests.swift
@@ -112,6 +112,18 @@ final class NativeNavigationUITests: XCTestCase {
112112 ) throws {
113113 let capture = try captureScroll(element, in: scroll, application: application)
114114 func assertFrames(_ actual: [CGRect], _ expected: [CGRect], _ name: String) {
115 // XCTest can report offscreen accessibility nodes as (inf, inf, 0, 0).
116 // They cannot participate in a gesture, and the snapshot correctly
117 // omits them, so compare only finite, non-empty geometry.
118 let valid: ([CGRect]) -> [CGRect] = { frames in
119 frames.filter { frame in
120 frame.minX.isFinite && frame.minY.isFinite
121 && frame.width.isFinite && frame.height.isFinite
122 && !frame.isEmpty
123 }
124 }
125 let actual = valid(actual)
126 let expected = valid(expected)
115127 XCTAssertEqual(actual.count, expected.count, "snapshot lost \(name)")
116128 for frame in expected {
117129 XCTAssertTrue(actual.contains { candidate in