ReviewOS

also looking at this

craft-native/craft

fix(native): preserve workspace sources and native overlay lifecycle

#384
Merged chris wants to merge codex/windows-zig-cache-diagnostics into main
20 files +500 -227

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/ios/src/index.test.tsmodified+1-1
Changes to packages/ios/src/index.test.ts
@@ -271,7 +271,7 @@ describe('Craft iOS builder', () => {
271271 expect(nativeSwift).toContain('modal.setVisible(visible, opacity: number(style["opacity"]) ?? 1, animationType: props["animationType"] as? String)')
272272 expect(nativeSwift).toContain('if let propVisible = props["visible"] as? Bool')
273273 expect(nativeSwift).toContain('visible = display != nil && display != "none"')
274 expect(nativeSwift).toContain('!($0 is CraftNativeModalView)')
274 expect(nativeSwift).toContain('!($0.element is CraftNativeModalView)')
275275 expect(nativeSwift).toContain('button.isEnabled = props["disabled"] as? Bool != true')
276276 expect(nativeSwift).toContain('let transformedTitle = transformedText(title, style: style)')
277277 expect(nativeSwift).toContain('private func transformedText(_ text: String, style: [String: Any])')