ReviewOS

also looking at this

craft-native/craft

fix(build): select the core Zig project explicitly

#383
Merged chris wants to merge codex/zig-core-build-root into main
4 files +44 -2
9 days ago

Tagged Windows builds selected the monorepo wrapper and rejected -Dversion, blocking publication of releases 252 and 253. Core zig build invocations now explicitly select the absolute packages/zig/build.zig using Zig’s supported --build-file option. Keep the requested working directory, pinned compiler, version, optimization arguments and compiler exit status; non-build commands retain their argument semantics.

The Windows job compiles the full CLI before running a regression fixture, so qualification cannot depend on the fixture warming the compiler. The fixture lives on the checkout volume and invokes the actual pinned compiler through the package-owned launcher against a minimal nested project. Only the core project accepts the package-version option. All scratch files are removed afterward. Log the selected project directory for native-host diagnosis. Upstream journey-fetch improvements and release 253 are retained.

Validation: all 13 source gates passed on eaddd66 in 39388281661, including cold Windows compilation, the real-compiler regression, packaged installation/launch/multi-window behavior, macOS and Linux installed-app acceptance, Android generated projects, iOS/Watch templates, and stock software-emulator readiness/cleanup. Local validation passed 746 SDK tests, 43 toolchain/release contracts, types, zero-error Pickier, all 8 npm archives with 16 installed entry points, and 43 package-surface checks. Full exact-tag source/native/archive/scan/download gates remain required before public publication; existing immutable tags are unchanged.

Reference: Zig build-file selection.

4 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.