Commit 32 of 75:
e8abe433d7
fix(tests): pass native modal close details to the fixture handler
previous
next
whole branch
Review threads live on the whole diff, not on one commit, so
none are shown here - a thread's line means something in the
branch's final form, and painting it into an intermediate
step would put it on code it is not about.
packages/ios/fixtures/native-navigation/Home.stx modified +1 -1 Changes to packages/ios/fixtures/native-navigation/Home.stx ⋯ 833 lines Show the 833 lines above this hunk function openDetailsThenUpdateBackground() { 834 834 < Text testID = "invalid-control-style-status" : text = "invalidControlStyleStatus" / > 835 835 < Text testID = "date-event-status" : text = "dateEventStatus" / > 836 836 < Button testID = "toggle-modal" @ click = "toggleModal()" > Toggle modal < / Button > 837 - < Modal testID = "native-modal" visible = { modalVisible } transparent animationType = "slide" style = { { "opacity" : modalOpacity } } @ show = "modalShown()" @ dismiss = "modalDismissed()" @ request - close = "modalRequested()" > 837 + < Modal testID = "native-modal" visible = { modalVisible } transparent animationType = "slide" style = { { "opacity" : modalOpacity } } @ show = "modalShown()" @ dismiss = "modalDismissed()" @ request - close = "modalRequested( $event )" > 838 838 < Text testID = "modal-content" > Modal content < / Text > 839 839 < Button testID = "toggle-modal-opacity" @ click = "toggleModalOpacity()" > Toggle modal opacity < / Button > 840 840 < Text testID = "modal-opacity" : text = "modalOpacity" / >
scripts/native-renderer-contract.test.ts modified +1 -1 Changes to scripts/native-renderer-contract.test.ts ⋯ 1,308 lines Show the 1,308 lines above this hunk describe('native renderer component contract', () => { 1309 1309 expect ( iosNavigationTest ) . toContain ( 'itemsPicker.waitForExistence(timeout: 5)' ) 1310 1310 expect ( androidNavigationTest ) . toContain ( 'items picker should be an Android Spinner' ) 1311 1311 expect ( androidNavigationTest ) . toContain ( 'awaitText(activity, "items-picker-value", "2.0")' ) 1312 - expect ( navigationHome ) . toContain ( '@request-close="modalRequested()"' ) 1312 + expect ( navigationHome ) . toContain ( '@request-close="modalRequested( $event )"' ) 1313 1313 expect ( navigationHome ) . toContain ( '@show="modalShown()"' ) 1314 1314 expect ( navigationHome ) . toContain ( 'testID="clear-image-source"' ) 1315 1315 expect ( navigationHome ) . toContain ( 'testID="image-error-count"' )