ReviewOS

also looking at this

craft-native/craft

fix(mobile): preserve native editing, navigation, and durable media requests

#369
Merged chris wants to merge codex/native-vertical-scroll-tab-swipes into main
36 files +864 -185

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/ios/fixtures/native-navigation/NativeNavigationUITests.swiftmodified+7-1
Changes to packages/ios/fixtures/native-navigation/NativeNavigationUITests.swift
@@ -167,7 +167,13 @@ final class NativeNavigationUITests: XCTestCase {
167167 reveal(notes, in: root)
168168 notes.tap()
169169 XCTAssertTrue(app.keyboards.firstMatch.waitForExistence(timeout: 5), "The scroll container dismissed the text area's keyboard")
170 notes.typeText(" edited")
170 // A native tap can place the caret anywhere. Exercise the review edit
171 // interaction explicitly instead of assuming insertion is at the end.
172 notes.press(forDuration: 1)
173 let selectAll = app.descendants(matching: .any).matching(NSPredicate(format: "label == %@", "Select All")).firstMatch
174 XCTAssertTrue(selectAll.waitForExistence(timeout: 5), "The text area must retain its native selection menu")
175 selectAll.tap()
176 notes.typeText("Draft edited")
171177 XCTAssertEqual(notes.value as? String, "Draft edited")
172178 notes.tap()
173179 XCTAssertTrue(app.keyboards.firstMatch.exists, "Tapping the text area again must preserve editing")