ReviewOS

also looking at this

craft-native/craft

fix(mobile): preserve native editing, navigation, and durable media requests

#369
Merged chris wants to merge codex/native-vertical-scroll-tab-swipes into main
36 files +864 -185

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/mobile-e2e.ymlmodified+5-5
Changes to .github/workflows/mobile-e2e.yml
@@ -171,7 +171,7 @@ jobs:
171171 uses: actions/checkout@v6
172172 with:
173173 repository: stacksjs/stx
174 ref: 0d85afbab4b569ac2f09113a6c9a5d11d926145f
174 ref: 396cb876707e2b0668374c818ea93aa38dac04f8
175175 path: .stx-compiler
176176
177177 - name: Install stx compiler dependencies
@@ -287,12 +287,12 @@ jobs:
287287 # The summary requires both jobs, including every original test suite.
288288 # The multi-screen fixture is compiled from real .stx sources. Pin the
289289 # @stacksjs/stx compiler (`stx native compile`) so this job cannot silently change
290 # underneath us. This release also carries a Bun-compatible lockfile.
290 # underneath us. Bun 1.4.2 installs this release's frozen lockfile.
291291 - name: Checkout stx compiler
292292 uses: actions/checkout@v6
293293 with:
294294 repository: stacksjs/stx
295 ref: 0d85afbab4b569ac2f09113a6c9a5d11d926145f
295 ref: 396cb876707e2b0668374c818ea93aa38dac04f8
296296 path: .stx-compiler
297297
298298 - name: Install stx compiler dependencies
@@ -442,7 +442,7 @@ jobs:
442442 uses: actions/checkout@v6
443443 with:
444444 repository: stacksjs/stx
445 ref: 0d85afbab4b569ac2f09113a6c9a5d11d926145f
445 ref: 396cb876707e2b0668374c818ea93aa38dac04f8
446446 path: .stx-compiler
447447
448448 - name: Install Android stx compiler dependencies
@@ -649,7 +649,7 @@ jobs:
649649 - uses: actions/checkout@v6
650650 with:
651651 repository: stacksjs/stx
652 ref: 0d85afbab4b569ac2f09113a6c9a5d11d926145f
652 ref: 396cb876707e2b0668374c818ea93aa38dac04f8
653653 path: .stx-compiler
654654 - run: bun install --frozen-lockfile
655655 working-directory: .stx-compiler
scripts/release-workflow.test.tsmodified+1-1
Changes to scripts/release-workflow.test.ts
@@ -19,7 +19,7 @@ type Job = {
1919}
2020const release = Bun.YAML.parse(readFileSync(join(import.meta.dir, '../.github/workflows/release.yml'), 'utf8')) as { jobs: Record<string, Job> }
2121const artifactDownload = 'actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093'
22const stxCompilerCommit = '0d85afbab4b569ac2f09113a6c9a5d11d926145f'
22const stxCompilerCommit = '396cb876707e2b0668374c818ea93aa38dac04f8'
2323const needs = (job: Job) => typeof job.needs === 'string' ? [job.needs] : job.needs ?? []
2424const steps = (job: Job) => job.steps?.map(step => step.run ?? '').join('\n') ?? ''
2525