also looking at this
fix(mobile): preserve native editing, navigation, and durable media requests
#369
36 files
+864
-185
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -397,10 +397,10 @@ private class CraftNativeMapView(context: Context) : FrameLayout(context), OnMap | ||
| 397 | 397 | "$id:${value.first.latitude},${value.first.longitude}" |
| 398 | 398 | } |
| 399 | 399 | val polylineKey = polylines.toSortedMap().entries.joinToString("|") { (id, value) -> |
| 400 | "$id:" + value.points.joinToString(";") { point -> "${point.latitude},${point.longitude}" } | |
| 400 | "$id:" + value.first.joinToString(";") { point -> "${point.latitude},${point.longitude}" } | |
| 401 | 401 | } |
| 402 | 402 | val polygonKey = polygons.toSortedMap().entries.joinToString("|") { (id, value) -> |
| 403 | "$id:" + value.first.joinToString(";") { point -> "${point.latitude},${point.longitude}" } | |
| 403 | "$id:" + value.points.joinToString(";") { point -> "${point.latitude},${point.longitude}" } | |
| 404 | 404 | } |
| 405 | 405 | return "m[$markerKey]p[$polylineKey]g[$polygonKey]" |
| 406 | 406 | } |
| @@ -413,7 +413,6 @@ private class CraftNativeMapView(context: Context) : FrameLayout(context), OnMap | ||
| 413 | 413 | markers.values.forEach { builder.include(it.position); count++ } |
| 414 | 414 | polylines.values.flatMap { it.points }.forEach { builder.include(it); count++ } |
| 415 | 415 | polygons.values.flatMap { it.points }.forEach { builder.include(it); count++ } |
| 416 | polygons.values.flatMap { it.points }.forEach { builder.include(it); count++ } | |
| 417 | 416 | if (count == 0) return false |
| 418 | 417 | post { |
| 419 | 418 | if (width > 0 && height > 0) { |