ReviewOS

also looking at this

craft-native/craft

fix(mobile): preserve native editing, navigation, and durable media requests

#369
Merged chris wants to merge codex/native-vertical-scroll-tab-swipes into main
36 files +864 -185

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/mobile-e2e.ymlmodified+4-4
Changes to .github/workflows/mobile-e2e.yml
@@ -172,7 +172,7 @@ jobs:
172172 uses: actions/checkout@v6
173173 with:
174174 repository: stacksjs/stx
175 ref: 396cb876707e2b0668374c818ea93aa38dac04f8
175 ref: 4b1a10b3d4b6b02e36612a7ba88fb8f5c922d7a1
176176 path: .stx-compiler
177177
178178 - name: Install stx compiler dependencies
@@ -293,7 +293,7 @@ jobs:
293293 uses: actions/checkout@v6
294294 with:
295295 repository: stacksjs/stx
296 ref: 396cb876707e2b0668374c818ea93aa38dac04f8
296 ref: 4b1a10b3d4b6b02e36612a7ba88fb8f5c922d7a1
297297 path: .stx-compiler
298298
299299 - name: Install stx compiler dependencies
@@ -443,7 +443,7 @@ jobs:
443443 uses: actions/checkout@v6
444444 with:
445445 repository: stacksjs/stx
446 ref: 396cb876707e2b0668374c818ea93aa38dac04f8
446 ref: 4b1a10b3d4b6b02e36612a7ba88fb8f5c922d7a1
447447 path: .stx-compiler
448448
449449 - name: Install Android stx compiler dependencies
@@ -650,7 +650,7 @@ jobs:
650650 - uses: actions/checkout@v6
651651 with:
652652 repository: stacksjs/stx
653 ref: 396cb876707e2b0668374c818ea93aa38dac04f8
653 ref: 4b1a10b3d4b6b02e36612a7ba88fb8f5c922d7a1
654654 path: .stx-compiler
655655 - run: bun install --frozen-lockfile
656656 working-directory: .stx-compiler
docs/guides/native-stx.mdmodified+1-1
Changes to docs/guides/native-stx.md
@@ -73,7 +73,7 @@ renderer.
7373The maintained Mobile E2E workflow checks out one exact stx compiler commit for
7474both simulator hosts. Update the iOS and Android refs together; the workflow
7575contract test rejects compiler skew between them.
76The current pair is pinned to `396cb876707e2b0668374c818ea93aa38dac04f8`,
76The current pair is pinned to `4b1a10b3d4b6b02e36612a7ba88fb8f5c922d7a1`,
7777which preserves authored reconciliation keys and explicit grid row tracks in
7878static and reactive native styles. The native fixtures qualify its compiled
7979properties and mutation metadata together with both native models. Application
scripts/release-workflow.test.tsmodified+1-1
Changes to scripts/release-workflow.test.ts
@@ -19,7 +19,7 @@ type Job = {
1919}
2020const release = Bun.YAML.parse(readFileSync(join(import.meta.dir, '../.github/workflows/release.yml'), 'utf8')) as { jobs: Record<string, Job> }
2121const artifactDownload = 'actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093'
22const stxCompilerCommit = '396cb876707e2b0668374c818ea93aa38dac04f8'
22const stxCompilerCommit = '4b1a10b3d4b6b02e36612a7ba88fb8f5c922d7a1'
2323const needs = (job: Job) => typeof job.needs === 'string' ? [job.needs] : job.needs ?? []
2424const steps = (job: Job) => job.steps?.map(step => step.run ?? '').join('\n') ?? ''
2525