also looking at this
fix(mobile): preserve native editing, navigation, and durable media requests
#369
Merged
chris
wants to merge
codex/native-vertical-scroll-tab-swipes
into
main
36 files
+864
-185
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -147,7 +147,7 @@ class NativeFlatListTest { | ||
| 147 | 147 | instrumentation.runOnMainSync { |
| 148 | 148 | list = CraftNativeFlatList(context) |
| 149 | 149 | attach(list) |
| 150 | - list.apply(rows, false, 1, false, 0.1, renderer(context, renders), { _ -> }, null, null) | |
| 150 | + list.apply(rows, false, 1, false, 0.1, renderer(context, renders), { _ -> }, { _ -> }, null) | |
| 151 | 151 | } |
| 152 | 152 | awaitCount(list, 10_000) |
| 153 | 153 | instrumentation.runOnMainSync { |
| @@ -163,7 +163,7 @@ class NativeFlatListTest { | ||
| 163 | 163 | |
| 164 | 164 | val moved = listOf(rows[1], rows[0]) + rows.drop(2) |
| 165 | 165 | instrumentation.runOnMainSync { |
| 166 | - list.apply(moved, false, 1, false, 0.1, renderer(context, renders), { _ -> }, null, null) | |
| 166 | + list.apply(moved, false, 1, false, 0.1, renderer(context, renders), { _ -> }, { _ -> }, null) | |
| 167 | 167 | } |
| 168 | 168 | awaitCount(list, 10_000) |
| 169 | 169 | instrumentation.runOnMainSync { attach(list) } |
| @@ -186,7 +186,7 @@ class NativeFlatListTest { | ||
| 186 | 186 | list.onScrollEvent = { scrollCount.incrementAndGet() } |
| 187 | 187 | list.onMomentumScrollBegin = { momentumBeginCount.incrementAndGet() } |
| 188 | 188 | list.onMomentumScrollEnd = { momentumEndCount.incrementAndGet() } |
| 189 | - list.apply(rows, false, 1, false, 0.1, renderer(context, AtomicInteger()), { _ -> }, null, null) | |
| 189 | + list.apply(rows, false, 1, false, 0.1, renderer(context, AtomicInteger()), { _ -> }, { _ -> }, null) | |
| 190 | 190 | } |
| 191 | 191 | awaitCount(list, 100) |
| 192 | 192 | instrumentation.runOnMainSync { |
| @@ -214,7 +214,7 @@ class NativeFlatListTest { | ||
| 214 | 214 | instrumentation.runOnMainSync { |
| 215 | 215 | list = CraftNativeFlatList(context) |
| 216 | 216 | attach(list) |
| 217 | - list.apply(nodes, true, 1, true, 0.1, renderer(context, renders), { _ -> }, null, null) | |
| 217 | + list.apply(nodes, true, 1, true, 0.1, renderer(context, renders), { _ -> }, { _ -> }, null) | |
| 218 | 218 | } |
| 219 | 219 | awaitCount(list, 9) |
| 220 | 220 | val horizontal = list.layoutManager as LinearLayoutManager |
| @@ -224,7 +224,7 @@ class NativeFlatListTest { | ||
| 224 | 224 | assertEquals("mounted identities must stay in adapter order", invertedIdentities, invertedIdentities.sortedBy { it.substringAfter('-').toInt() }) |
| 225 | 225 | |
| 226 | 226 | instrumentation.runOnMainSync { |
| 227 | - list.apply(nodes, false, 3, false, 0.1, renderer(context, renders), { _ -> }, null, null) | |
| 227 | + list.apply(nodes, false, 3, false, 0.1, renderer(context, renders), { _ -> }, { _ -> }, null) | |
| 228 | 228 | } |
| 229 | 229 | awaitCount(list, 9) |
| 230 | 230 | SystemClock.sleep(200) |
| @@ -236,7 +236,7 @@ class NativeFlatListTest { | ||
| 236 | 236 | val updated = listOf(chrome("header", "header"), row(0).put("children", JSONArray().put("Updated"))) + |
| 237 | 237 | (1 until 8).map(::row) |
| 238 | 238 | instrumentation.runOnMainSync { |
| 239 | - list.apply(updated, false, 3, false, 0.1, renderer(context, renders), { _ -> }, null, null) | |
| 239 | + list.apply(updated, false, 3, false, 0.1, renderer(context, renders), { _ -> }, { _ -> }, null) | |
| 240 | 240 | } |
| 241 | 241 | SystemClock.sleep(300) |
| 242 | 242 | instrumentation.runOnMainSync { attach(list) } |
| @@ -248,7 +248,7 @@ class NativeFlatListTest { | ||
| 248 | 248 | chrome("footer", "footer"), |
| 249 | 249 | ) |
| 250 | 250 | instrumentation.runOnMainSync { |
| 251 | - list.apply(chromeOnly, false, 1, false, 0.1, renderer(context, renders), { _ -> }, null, { | |
| 251 | + list.apply(chromeOnly, false, 1, false, 0.1, renderer(context, renders), { _ -> }, { _ -> }, { | |
| 252 | 252 | chromeEndReached.incrementAndGet() |
| 253 | 253 | }) |
| 254 | 254 | } |
| @@ -266,7 +266,7 @@ class NativeFlatListTest { | ||
| 266 | 266 | assertTrue("vertical indicator should be hidden", !list.isVerticalScrollBarEnabled) |
| 267 | 267 | assertTrue("horizontal indicator should be visible", list.isHorizontalScrollBarEnabled) |
| 268 | 268 | assertEquals(View.OVER_SCROLL_NEVER, list.overScrollMode) |
| 269 | - list.apply(emptyList(), true, 1, false, 0.1, renderer(context, AtomicInteger()), { _ -> }, null, null) | |
| 269 | + list.apply(emptyList(), true, 1, false, 0.1, renderer(context, AtomicInteger()), { _ -> }, { _ -> }, null) | |
| 270 | 270 | list.setBounceOptions(enabled = true, vertical = false, horizontal = true) |
| 271 | 271 | assertEquals(View.OVER_SCROLL_ALWAYS, list.overScrollMode) |
| 272 | 272 | list.setBounceOptions(enabled = false, vertical = true, horizontal = true) |
| @@ -291,7 +291,7 @@ class NativeFlatListTest { | ||
| 291 | 291 | instrumentation.runOnMainSync { |
| 292 | 292 | list.setScrollEnabled(false) |
| 293 | 293 | list.onContentSizeChanged = { contentSizeChanges.incrementAndGet() } |
| 294 | - list.apply(rows, false, 1, false, 0.1, renderer(context, AtomicInteger()), { _ -> }, null, null) | |
| 294 | + list.apply(rows, false, 1, false, 0.1, renderer(context, AtomicInteger()), { _ -> }, { _ -> }, null) | |
| 295 | 295 | } |
| 296 | 296 | awaitCount(list, rows.size) |
| 297 | 297 | instrumentation.runOnMainSync { |
| @@ -387,7 +387,7 @@ class NativeFlatListTest { | ||
| 387 | 387 | } |
| 388 | 388 | }, |
| 389 | 389 | { _ -> }, |
| 390 | - null, | |
| 390 | + { _ -> }, | |
| 391 | 391 | null, |
| 392 | 392 | ) |
| 393 | 393 | } |
| @@ -424,7 +424,7 @@ class NativeFlatListTest { | ||
| 424 | 424 | } |
| 425 | 425 | }, |
| 426 | 426 | { _ -> }, |
| 427 | - null, | |
| 427 | + { _ -> }, | |
| 428 | 428 | null, |
| 429 | 429 | ) |
| 430 | 430 | } |
| @@ -465,7 +465,7 @@ class NativeFlatListTest { | ||
| 465 | 465 | } |
| 466 | 466 | }, |
| 467 | 467 | { _ -> }, |
| 468 | - null, | |
| 468 | + { _ -> }, | |
| 469 | 469 | null, |
| 470 | 470 | ) |
| 471 | 471 | } |