also looking at this
fix(mobile): preserve native editing, navigation, and durable media requests
#369
36 files
+864
-185
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -1960,7 +1960,7 @@ final class NativeRenderUnitTests: XCTestCase { | ||
| 1960 | 1960 | XCTAssertEqual(controller.evaluateScript("__rowPress")?.toString(), "select-b") |
| 1961 | 1961 | } |
| 1962 | 1962 | |
| 1963 | func testScrollCanCancelButtonTrackingWithoutTakingSliderOrInputTracking() throws { | |
| 1963 | func testScrollCanCancelButtonAndFieldTrackingWithoutTakingValueControls() throws { | |
| 1964 | 1964 | let controller = CraftNativeScreenController(config: CraftConfig()) |
| 1965 | 1965 | controller.loadViewIfNeeded() |
| 1966 | 1966 | controller.render(document([[ |
| @@ -1975,7 +1975,7 @@ final class NativeRenderUnitTests: XCTestCase { | ||
| 1975 | 1975 | XCTAssertTrue(form.touchesShouldCancel(in: try XCTUnwrap(find(UIButton.self, key: "action", below: controller.view)))) |
| 1976 | 1976 | XCTAssertFalse(form.touchesShouldCancel(in: try XCTUnwrap(find(UISlider.self, key: "position", below: controller.view)))) |
| 1977 | 1977 | XCTAssertFalse(form.touchesShouldCancel(in: try XCTUnwrap(find(UISwitch.self, key: "toggle", below: controller.view)))) |
| 1978 | XCTAssertFalse(form.touchesShouldCancel(in: try XCTUnwrap(find(UITextField.self, key: "draft", below: controller.view)))) | |
| 1978 | XCTAssertTrue(form.touchesShouldCancel(in: try XCTUnwrap(find(UITextField.self, key: "draft", below: controller.view)))) | |
| 1979 | 1979 | } |
| 1980 | 1980 | |
| 1981 | 1981 | func testScrollKeyboardTapPreservesTextAreaFocusAndSelectionButDismissesBackground() throws { |