also looking at this
fix(native): retain keyed controls and correct map and tab chrome
#368
32 files
+449
-100
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -167,7 +167,7 @@ jobs: | ||
| 167 | 167 | uses: actions/checkout@v6 |
| 168 | 168 | with: |
| 169 | 169 | repository: stacksjs/stx |
| 170 | ref: 3dd3240fc9a64f360e9690eee50c483be3325705 | |
| 170 | ref: 413b21432886fda5c610e7eaaaa2ad95dce2f04f | |
| 171 | 171 | path: .stx-compiler |
| 172 | 172 | |
| 173 | 173 | - name: Install stx compiler dependencies |
| @@ -286,7 +286,7 @@ jobs: | ||
| 286 | 286 | uses: actions/checkout@v6 |
| 287 | 287 | with: |
| 288 | 288 | repository: stacksjs/stx |
| 289 | ref: 3dd3240fc9a64f360e9690eee50c483be3325705 | |
| 289 | ref: 413b21432886fda5c610e7eaaaa2ad95dce2f04f | |
| 290 | 290 | path: .stx-compiler |
| 291 | 291 | |
| 292 | 292 | - name: Install stx compiler dependencies |
| @@ -434,7 +434,7 @@ jobs: | ||
| 434 | 434 | uses: actions/checkout@v6 |
| 435 | 435 | with: |
| 436 | 436 | repository: stacksjs/stx |
| 437 | ref: 3dd3240fc9a64f360e9690eee50c483be3325705 | |
| 437 | ref: 413b21432886fda5c610e7eaaaa2ad95dce2f04f | |
| 438 | 438 | path: .stx-compiler |
| 439 | 439 | |
| 440 | 440 | - name: Install Android stx compiler dependencies |
| @@ -642,7 +642,7 @@ jobs: | ||
| 642 | 642 | - uses: actions/checkout@v6 |
| 643 | 643 | with: |
| 644 | 644 | repository: stacksjs/stx |
| 645 | ref: 3dd3240fc9a64f360e9690eee50c483be3325705 | |
| 645 | ref: 413b21432886fda5c610e7eaaaa2ad95dce2f04f | |
| 646 | 646 | path: .stx-compiler |
| 647 | 647 | - run: bun install --no-save |
| 648 | 648 | working-directory: .stx-compiler |
| @@ -61,9 +61,10 @@ capability APIs from the host. | ||
| 61 | 61 | The maintained Mobile E2E workflow checks out one exact stx compiler commit for |
| 62 | 62 | both simulator hosts. Update the iOS and Android refs together; the workflow |
| 63 | 63 | contract test rejects compiler skew between them. |
| 64 | The current pair is pinned to `3dd3240fc9a64f360e9690eee50c483be3325705`, | |
| 65 | which keeps a container's testID around a library component, draws `Checkbox` | |
| 66 | natively and keeps a style object's `transform` and `shadowOffset`. | |
| 64 | The current pair is pinned to `413b21432886fda5c610e7eaaaa2ad95dce2f04f`, | |
| 65 | which preserves authored reconciliation keys in created and cloned native nodes. | |
| 66 | This qualifies the compiler and native mutation models together; release qualification | |
| 67 | must use the corresponding normally published compiler before consumer adoption. | |
| 67 | 68 | |
| 68 | 69 | The host-neutral layout contract lives in Craft's Zig runtime at |
| 69 | 70 | `packages/zig/src/native_layout.zig`. It defines the shared row/column flex |
| @@ -18,7 +18,7 @@ type Job = { | ||
| 18 | 18 | } |
| 19 | 19 | const release = Bun.YAML.parse(readFileSync(join(import.meta.dir, '../.github/workflows/release.yml'), 'utf8')) as { jobs: Record<string, Job> } |
| 20 | 20 | const artifactDownload = 'actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093' |
| 21 | const stxCompilerCommit = '3dd3240fc9a64f360e9690eee50c483be3325705' | |
| 21 | const stxCompilerCommit = '413b21432886fda5c610e7eaaaa2ad95dce2f04f' | |
| 22 | 22 | const needs = (job: Job) => typeof job.needs === 'string' ? [job.needs] : job.needs ?? [] |
| 23 | 23 | const steps = (job: Job) => job.steps?.map(step => step.run ?? '').join('\n') ?? '' |
| 24 | 24 | |