Commit 19 of 23:
dbf16224f0
test(ios): reproduce appearance from a tab without an accessory
previous
next
whole branch
Review threads live on the whole diff, not on one commit, so
none are shown here - a thread's line means something in the
branch's final form, and painting it into an intermediate
step would put it on code it is not about.
packages/ios/fixtures/native-navigation/NativeNavigationUnitTests.swift modified +2 -2 Changes to packages/ios/fixtures/native-navigation/NativeNavigationUnitTests.swift ⋯ 419 lines Show the 419 lines above this hunk @@ -420,7 +420,7 @@ final class NativeNavigationUnitTests: XCTestCase { 420 420 } 421 421 422 422 func testNativePushKeepsItsAccessoryAfterTabPreparation ( ) async throws { 423 - await displayWait ( "the Details tab is prepared" ) { [ self ] in stack ( "/ details " ) ! = nil } 423 + await displayWait ( "the Third tab is prepared" ) { [ self ] in stack ( "/ third " ) ! = nil } 424 424 let home = try XCTUnwrap ( stack ( "/" ) ) 425 425 let root = try XCTUnwrap ( home . topViewController as ? CraftNativeScreenController ) 426 426 func button ( in view : UIView ) - > UIButton ? { ⋯ 9 lines Show the 9 lines above this hunk @@ -436,7 +436,7 @@ final class NativeNavigationUnitTests: XCTestCase { 436 436 XCTAssertEqual ( CraftChrome . shared . selected , "/" ) 437 437 XCTAssertEqual ( CraftChrome . shared . tabAccessory ? . id , "/capabilities" ) 438 438 439 - let background = try XCTUnwrap ( stack ( "/ details " ) ) 439 + let background = try XCTUnwrap ( stack ( "/ third " ) ) 440 440 XCTAssertTrue ( background . view . isHidden ) 441 441 let prepared = try XCTUnwrap ( background . topViewController as ? CraftNativeScreenController ) 442 442