ReviewOS

also looking at this

craft-native/craft

fix(native): retain keyed controls and correct map and tab chrome

#368
Merged chris wants to merge codex/native-repeated-selector-identity into main
32 files +449 -100

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeNavigationTest.ktmodified+5-1
Changes to packages/android/fixtures/native-navigation/NativeNavigationTest.kt
@@ -780,7 +780,11 @@ class NativeNavigationTest {
780780 .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_ACTIVITY_CLEAR_TASK)
781781 ) as MainActivity
782782 fun rows(): List<View> {
783 val list = awaitView(activity, "identity-list")
783 val list = awaitView(activity, "identity-list") { candidate ->
784 val rendered = mutableListOf<View>()
785 findAll(candidate, "identity-row", rendered)
786 rendered.size == 2
787 }
784788 val matches = mutableListOf<View>()
785789 instrumentation.runOnMainSync {
786790 findAll(list, "identity-row", matches)