ReviewOS
Reload

also looking at this

craft-native/craft

feat(maps): add key-free native Android maps and shared map controls

#363
Merged chris wants to merge codex/wildloop-native-map-providers into main
28 files +1857 -481

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeMapTest.ktmodified+3-0
@@ -253,6 +253,9 @@ class NativeMapTest {
253253 awaitBasemapPixels(host, "before-background")
254254 val camera = main { map.cameraPosition }
255255 assertTrue("The system Home action must succeed", instrumentation.uiAutomation.performGlobalAction(android.accessibilityservice.AccessibilityService.GLOBAL_ACTION_HOME))
256 awaitState("Home must stop the native map activity before testing its restoration") {
257 activity.lifecycle.currentState == androidx.lifecycle.Lifecycle.State.CREATED && !activity.hasWindowFocus()
258 }
256259 instrumentation.uiAutomation.waitForIdle(500, 5_000)
257260 assertNotEquals("The Home action must actually background the app", activity.packageName, instrumentation.uiAutomation.rootInActiveWindow?.packageName?.toString())
258261 // startActivitySync waits for a new Activity creation; this Intent