also looking at this
feat(maps): add key-free native Android maps and shared map controls
#363
28 files
+1857
-481
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -1,4 +1,4 @@ | ||
| 1 | import { copyFileSync } from 'node:fs' | |
| 1 | import { copyFileSync, existsSync } from 'node:fs' | |
| 2 | 2 | import { join } from 'node:path' |
| 3 | 3 | import { Glob } from 'bun' |
| 4 | 4 | import { bootSimulator, init, pickSimulator, type CraftConfig } from '../src/index' |
| @@ -113,8 +113,19 @@ function run(args: string[], cwd: string, label: string): void { | ||
| 113 | 113 | stdout: 'inherit', |
| 114 | 114 | stderr: 'inherit', |
| 115 | 115 | }) |
| 116 | if (result.exitCode !== 0) | |
| 116 | if (result.exitCode !== 0) { | |
| 117 | const bundleIndex = args.indexOf('-resultBundlePath') | |
| 118 | const bundle = bundleIndex < 0 ? undefined : args[bundleIndex + 1] | |
| 119 | if (args[0] === 'xcodebuild' && bundle && existsSync(bundle)) { | |
| 120 | console.log('xcodebuild failed; reporting XCTest diagnostics before fixture cleanup') | |
| 121 | for (const view of ['summary', 'tests']) { | |
| 122 | Bun.spawnSync(['xcrun', 'xcresulttool', 'get', 'test-results', view, '--path', bundle], { | |
| 123 | cwd, stdout: 'inherit', stderr: 'inherit', | |
| 124 | }) | |
| 125 | } | |
| 126 | } | |
| 117 | 127 | throw new Error(`${label} exited with ${result.exitCode}`) |
| 128 | } | |
| 118 | 129 | } |
| 119 | 130 | |
| 120 | 131 | /** |