ReviewOS

also looking at this

craft-native/craft

feat(maps): add key-free native Android maps and shared map controls

#363
Merged chris wants to merge codex/wildloop-native-map-providers into main
28 files +1857 -481

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/ios/fixtures/native-screen/NativeLayoutUnitTests.swiftmodified+9-0
Changes to packages/ios/fixtures/native-screen/NativeLayoutUnitTests.swift
@@ -549,6 +549,15 @@ final class NativeLayoutUnitTests: XCTestCase {
549549
550550 // More rows: the header is redrawn and the list grows.
551551 controller.render(document(rows: 5))
552 // Diffable snapshots commit asynchronously, including the initial
553 // snapshot that can defer this second render. Wait for the rendered
554 // header before measuring geometry; synchronous layout cannot drain
555 // the collection view's snapshot completion callbacks.
556 let snapshotDeadline = Date().addingTimeInterval(5)
557 while Date() < snapshotDeadline,
558 (find("header-text", below: controller.view) as? UILabel)?.text != "5 sessions" {
559 RunLoop.main.run(until: Date(timeIntervalSinceNow: 0.01))
560 }
552561 settle(controller)
553562 let header = try XCTUnwrap(find("header-text", below: controller.view) as? UILabel)
554563 XCTAssertEqual(header.text, "5 sessions")