ReviewOS

also looking at this

craft-native/craft

feat(maps): add key-free native Android maps and shared map controls

#363
Merged chris wants to merge codex/wildloop-native-map-providers into main
28 files +1857 -481

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/ci.ymlmodified+1-1
Changes to .github/workflows/ci.yml
@@ -21,7 +21,7 @@ jobs:
2121 android-software-emulator:
2222 name: Android software emulator
2323 runs-on: ubuntu-latest
24 timeout-minutes: 35
24 timeout-minutes: 25
2525 steps:
2626 - uses: actions/checkout@v6
2727 - name: Install the managed Android toolchain
scripts/verify-android-emulator.tsmodified+0-3
Changes to scripts/verify-android-emulator.ts
@@ -26,10 +26,7 @@ try {
2626 session = await createAndroidEmulator({
2727 sdkRoot: join(owned, 'sdk'), sdkmanager, avdmanager,
2828 image: 'system-images;android-35;google_apis_playstore;x86_64',
29 // The stock Play image performs real first-boot dex optimization under TCG.
30 // Keep every readiness and package assertion; give this software run an explicit bound.
3129 acceleration: 'software', artifactsDirectory: artifacts,
32 bootTimeoutMs: 20 * 60_000,
3330 temporaryDirectory: owned, acceptLicenses: true,
3431 env: { JAVA_HOME: javaHome },
3532 })