also looking at this
feat(maps): add key-free native Android maps and shared map controls
#363
28 files
+1857
-481
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -35,9 +35,9 @@ jobs: | ||
| 35 | 35 | fetch-depth: 0 |
| 36 | 36 | |
| 37 | 37 | - name: Setup Zig |
| 38 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 38 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 39 | 39 | with: |
| 40 | version: '0.11.91' | |
| 40 | version: '0.11.92' | |
| 41 | 41 | - name: Install Linux dependencies |
| 42 | 42 | run: | |
| 43 | 43 | sudo apt-get update |
| @@ -49,9 +49,9 @@ jobs: | ||
| 49 | 49 | fetch-depth: 0 |
| 50 | 50 | |
| 51 | 51 | - name: Setup Zig |
| 52 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 52 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 53 | 53 | with: |
| 54 | version: '0.11.91' | |
| 54 | version: '0.11.92' | |
| 55 | 55 | - name: Install Linux dependencies |
| 56 | 56 | run: | |
| 57 | 57 | sudo apt-get update |
| @@ -25,9 +25,9 @@ jobs: | ||
| 25 | 25 | steps: |
| 26 | 26 | - uses: actions/checkout@v6 |
| 27 | 27 | - name: Install the managed Android toolchain |
| 28 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 28 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 29 | 29 | with: |
| 30 | version: '0.11.91' | |
| 30 | version: '0.11.92' | |
| 31 | 31 | install: 'false' |
| 32 | 32 | packages: bun.com@1.4.3 git-scm.org@2.53.0 openjdk.org@17.0.20.8 android.com/cmdline-tools@14742923.0.0 |
| 33 | 33 | - name: Boot and dispose the stock Play image through the SDK |
| @@ -55,9 +55,9 @@ jobs: | ||
| 55 | 55 | - uses: actions/checkout@v6 |
| 56 | 56 | |
| 57 | 57 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 58 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 58 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 59 | 59 | with: |
| 60 | version: '0.11.91' | |
| 60 | version: '0.11.92' | |
| 61 | 61 | |
| 62 | 62 | - name: Verify Zig installation |
| 63 | 63 | run: zig version |
| @@ -139,9 +139,9 @@ jobs: | ||
| 139 | 139 | - uses: actions/checkout@v6 |
| 140 | 140 | |
| 141 | 141 | - name: Setup Pantry (provides Bun and Zig) |
| 142 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 142 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 143 | 143 | with: |
| 144 | version: '0.11.91' | |
| 144 | version: '0.11.92' | |
| 145 | 145 | |
| 146 | 146 | - name: First-party Zig dependencies |
| 147 | 147 | uses: ./.github/actions/first-party-zig-deps |
| @@ -197,9 +197,9 @@ jobs: | ||
| 197 | 197 | - uses: actions/checkout@v6 |
| 198 | 198 | |
| 199 | 199 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 200 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 200 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 201 | 201 | with: |
| 202 | version: '0.11.91' | |
| 202 | version: '0.11.92' | |
| 203 | 203 | |
| 204 | 204 | - name: Install dependencies |
| 205 | 205 | run: bun install |
| @@ -242,9 +242,9 @@ jobs: | ||
| 242 | 242 | - uses: actions/checkout@v6 |
| 243 | 243 | |
| 244 | 244 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 245 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 245 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 246 | 246 | with: |
| 247 | version: '0.11.91' | |
| 247 | version: '0.11.92' | |
| 248 | 248 | |
| 249 | 249 | - name: Install dependencies |
| 250 | 250 | run: bun install |
| @@ -268,9 +268,9 @@ jobs: | ||
| 268 | 268 | - uses: actions/checkout@v6 |
| 269 | 269 | |
| 270 | 270 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 271 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 271 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 272 | 272 | with: |
| 273 | version: '0.11.91' | |
| 273 | version: '0.11.92' | |
| 274 | 274 | |
| 275 | 275 | - name: Install XcodeGen |
| 276 | 276 | run: brew install xcodegen |
| @@ -296,9 +296,9 @@ jobs: | ||
| 296 | 296 | - uses: actions/checkout@v6 |
| 297 | 297 | |
| 298 | 298 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 299 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 299 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 300 | 300 | with: |
| 301 | version: '0.11.91' | |
| 301 | version: '0.11.92' | |
| 302 | 302 | |
| 303 | 303 | - name: Setup Java |
| 304 | 304 | uses: actions/setup-java@v6 |
| @@ -346,9 +346,9 @@ jobs: | ||
| 346 | 346 | - uses: actions/checkout@v6 |
| 347 | 347 | |
| 348 | 348 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 349 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 349 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 350 | 350 | with: |
| 351 | version: '0.11.91' | |
| 351 | version: '0.11.92' | |
| 352 | 352 | |
| 353 | 353 | - name: Install dependencies |
| 354 | 354 | run: bun install |
| @@ -364,9 +364,9 @@ jobs: | ||
| 364 | 364 | - uses: actions/checkout@v6 |
| 365 | 365 | |
| 366 | 366 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 367 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 367 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 368 | 368 | with: |
| 369 | version: '0.11.91' | |
| 369 | version: '0.11.92' | |
| 370 | 370 | |
| 371 | 371 | - name: Install dependencies |
| 372 | 372 | run: bun install |
| @@ -390,9 +390,9 @@ jobs: | ||
| 390 | 390 | - uses: actions/checkout@v6 |
| 391 | 391 | |
| 392 | 392 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 393 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 393 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 394 | 394 | with: |
| 395 | version: '0.11.91' | |
| 395 | version: '0.11.92' | |
| 396 | 396 | |
| 397 | 397 | - name: Install dependencies |
| 398 | 398 | run: bun install |
| @@ -466,9 +466,9 @@ jobs: | ||
| 466 | 466 | - uses: actions/checkout@v6 |
| 467 | 467 | |
| 468 | 468 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 469 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 469 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 470 | 470 | with: |
| 471 | version: '0.11.91' | |
| 471 | version: '0.11.92' | |
| 472 | 472 | |
| 473 | 473 | - name: Install dependencies |
| 474 | 474 | run: bun install |
| @@ -523,9 +523,9 @@ jobs: | ||
| 523 | 523 | fetch-depth: 0 |
| 524 | 524 | |
| 525 | 525 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 526 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 526 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 527 | 527 | with: |
| 528 | version: '0.11.91' | |
| 528 | version: '0.11.92' | |
| 529 | 529 | |
| 530 | 530 | - name: Install Dependencies |
| 531 | 531 | run: bun install |
| @@ -111,9 +111,9 @@ jobs: | ||
| 111 | 111 | - uses: actions/checkout@v6 |
| 112 | 112 | |
| 113 | 113 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 114 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 114 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 115 | 115 | with: |
| 116 | version: '0.11.91' | |
| 116 | version: '0.11.92' | |
| 117 | 117 | |
| 118 | 118 | - name: Install dependencies |
| 119 | 119 | run: bun install --frozen-lockfile |
| @@ -265,9 +265,9 @@ jobs: | ||
| 265 | 265 | - uses: actions/checkout@v6 |
| 266 | 266 | |
| 267 | 267 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 268 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 268 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 269 | 269 | with: |
| 270 | version: '0.11.91' | |
| 270 | version: '0.11.92' | |
| 271 | 271 | |
| 272 | 272 | - name: Install XcodeGen |
| 273 | 273 | run: brew install xcodegen |
| @@ -389,9 +389,9 @@ jobs: | ||
| 389 | 389 | - uses: actions/checkout@v6 |
| 390 | 390 | |
| 391 | 391 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 392 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 392 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 393 | 393 | with: |
| 394 | version: '0.11.91' | |
| 394 | version: '0.11.92' | |
| 395 | 395 | |
| 396 | 396 | - name: Setup Java |
| 397 | 397 | uses: actions/setup-java@v6 |
| @@ -555,9 +555,9 @@ jobs: | ||
| 555 | 555 | - uses: actions/checkout@v6 |
| 556 | 556 | |
| 557 | 557 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 558 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 558 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 559 | 559 | with: |
| 560 | version: '0.11.91' | |
| 560 | version: '0.11.92' | |
| 561 | 561 | |
| 562 | 562 | - name: Cache Zig artifacts |
| 563 | 563 | uses: actions/cache@v5 |
| @@ -69,9 +69,9 @@ jobs: | ||
| 69 | 69 | fetch-depth: 0 |
| 70 | 70 | |
| 71 | 71 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 72 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 72 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 73 | 73 | with: |
| 74 | version: '0.11.91' | |
| 74 | version: '0.11.92' | |
| 75 | 75 | |
| 76 | 76 | - name: Install System Dependencies |
| 77 | 77 | if: matrix.platform.deps != '' |
| @@ -344,9 +344,9 @@ jobs: | ||
| 344 | 344 | # publish the Zig package here: a failed second leg would otherwise make |
| 345 | 345 | # an incomplete version visible in the pantry registry. |
| 346 | 346 | - name: Stage draft release |
| 347 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 347 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 348 | 348 | with: |
| 349 | version: '0.11.91' | |
| 349 | version: '0.11.92' | |
| 350 | 350 | install: 'false' |
| 351 | 351 | release: 'true' |
| 352 | 352 | release-draft: 'true' |
| @@ -435,9 +435,9 @@ jobs: | ||
| 435 | 435 | # paths; it does not rebuild a platform binary. The complete GitHub |
| 436 | 436 | # release is public before this registry version can become visible. |
| 437 | 437 | - name: Publish Zig package |
| 438 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 438 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 439 | 439 | with: |
| 440 | version: '0.11.91' | |
| 440 | version: '0.11.92' | |
| 441 | 441 | install: 'false' |
| 442 | 442 | publish: 'zig' |
| 443 | 443 | package-dir: packages/zig |
| @@ -644,9 +644,9 @@ jobs: | ||
| 644 | 644 | fetch-depth: 0 |
| 645 | 645 | |
| 646 | 646 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 647 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 647 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 648 | 648 | with: |
| 649 | version: '0.11.91' | |
| 649 | version: '0.11.92' | |
| 650 | 650 | |
| 651 | 651 | - name: Install Dependencies |
| 652 | 652 | run: bun install --frozen-lockfile |
| @@ -731,9 +731,9 @@ jobs: | ||
| 731 | 731 | fetch-depth: 0 |
| 732 | 732 | |
| 733 | 733 | - name: Setup Pantry (provides Bun, Zig, etc.) |
| 734 | uses: pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7 # v0.11.91 | |
| 734 | uses: pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9 # v0.11.92 | |
| 735 | 735 | with: |
| 736 | version: '0.11.91' | |
| 736 | version: '0.11.92' | |
| 737 | 737 | - uses: actions/setup-node@v6 |
| 738 | 738 | with: |
| 739 | 739 | node-version: '24' |
| @@ -101,8 +101,8 @@ test('workflow setup uses a known Pantry CLI instead of resolving latest', () => | ||
| 101 | 101 | for (const [name, job] of Object.entries(workflow.jobs)) { |
| 102 | 102 | for (const step of job.steps ?? []) { |
| 103 | 103 | if (step.uses?.startsWith('pantry-pm/pantry/packages/action@')) { |
| 104 | expect(step.with?.version, `${file} ${name} must pin Pantry CLI`).toBe('0.11.91') | |
| 105 | expect(step.uses, `${file} ${name} must pin the matching action source`).toBe('pantry-pm/pantry/packages/action@2b6653b20b830c152f7491847a91d2d9d7cf4cc7') | |
| 104 | expect(step.with?.version, `${file} ${name} must pin Pantry CLI`).toBe('0.11.92') | |
| 105 | expect(step.uses, `${file} ${name} must pin the matching action source`).toBe('pantry-pm/pantry/packages/action@edda9c23439a37a35e0f828315e2380889cc75e9') | |
| 106 | 106 | } |
| 107 | 107 | } |
| 108 | 108 | } |
| @@ -250,7 +250,7 @@ test('a failed native leg cannot publish a partial GitHub, Zig, or npm release', | ||
| 250 | 250 | expect(release.jobs.npm.if).toContain("needs.prepare-npm.result == 'success'") |
| 251 | 251 | expect(release.jobs.npm.if).toContain("needs.publish-release.result == 'success'") |
| 252 | 252 | const zigPublish = registry.steps!.find(step => step.name === 'Publish Zig package') |
| 253 | expect(zigPublish?.with).toMatchObject({ version: '0.11.91', install: 'false', publish: 'zig', 'package-dir': 'packages/zig' }) | |
| 253 | expect(zigPublish?.with).toMatchObject({ version: '0.11.92', install: 'false', publish: 'zig', 'package-dir': 'packages/zig' }) | |
| 254 | 254 | expect(zigPublish?.with?.release).toBeUndefined() |
| 255 | 255 | expect(Object.entries(release.jobs).flatMap(([name, job]) => |
| 256 | 256 | (job.steps ?? []).filter(step => step.with?.publish === 'zig').map(() => name))).toEqual(['publish-pantry']) |