also looking at this
feat(maps): add key-free native Android maps and shared map controls
#363
28 files
+1857
-481
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -601,7 +601,7 @@ final class NativeLayoutUnitTests: XCTestCase { | ||
| 601 | 601 | XCTAssertEqual(after.maxX, before.maxX, accuracy: 1, "absolute sibling changed horizontal position") |
| 602 | 602 | } |
| 603 | 603 | |
| 604 | func testAbsoluteChildrenHonorSizeBoundsAndKeepTheirInsetAnchors() throws { | |
| 604 | func testAbsoluteChildrenHonorSizeBoundsAndKeepTheirInsetAnchors() async throws { | |
| 605 | 605 | let controller = screen(box("root", style: ["height": 240], [ |
| 606 | 606 | ["id": "expand", "type": "Button", "props": ["testID": "expand", "title": "+"], |
| 607 | 607 | "style": ["position": "absolute", "top": 12, "right": 12, "minWidth": 44, "minHeight": 44]], |
| @@ -610,7 +610,7 @@ final class NativeLayoutUnitTests: XCTestCase { | ||
| 610 | 610 | box("tall-ratio", style: ["position": "absolute", "left": 110, "top": 0, "height": 120, "aspectRatio": 2, "maxHeight": 60]), |
| 611 | 611 | text("wrapped", "An absolutely positioned label still wraps at its authored maximum width", style: ["position": "absolute", "left": 12, "top": 12, "maxWidth": 80, "fontSize": 17]), |
| 612 | 612 | ])) |
| 613 | settle(controller) | |
| 613 | await settle(controller) | |
| 614 | 614 | let root = try frame("root", in: controller) |
| 615 | 615 | let expand = try frame("expand", in: controller) |
| 616 | 616 | XCTAssertGreaterThanOrEqual(expand.width, 44) |