ReviewOS

also looking at this

craft-native/craft

feat(maps): add key-free native Android maps and shared map controls

#363
Merged chris wants to merge codex/wildloop-native-map-providers into main
28 files +1857 -481

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeMapTest.ktmodified+2-2
Changes to packages/android/fixtures/native-navigation/NativeMapTest.kt
@@ -11,7 +11,6 @@ import android.view.ViewGroup
1111import android.widget.TextView
1212import androidx.test.ext.junit.runners.AndroidJUnit4
1313import androidx.test.platform.app.InstrumentationRegistry
14import androidx.test.uiautomator.UiDevice
1514import java.io.File
1615import java.util.concurrent.CountDownLatch
1716import java.util.concurrent.TimeUnit
@@ -175,7 +174,8 @@ class NativeMapTest {
175174 host.configure(props().put("showsUserLocation", true), overlays()) {}
176175 assertFalse(map.locationComponent.isLocationComponentActivated)
177176 }
178 assertEquals("Rendering a map must not open a permission dialog", activity.packageName, UiDevice.getInstance(instrumentation).currentPackageName)
177 instrumentation.uiAutomation.waitForIdle(500, 5_000)
178 assertEquals("Rendering a map must not open a permission dialog", activity.packageName, instrumentation.uiAutomation.rootInActiveWindow?.packageName?.toString())
179179 evidence("map-location-permission-not-requested")
180180 }
181181}