ReviewOS

also looking at this

craft-native/craft

feat(maps): add key-free native Android maps and shared map controls

#363
Merged chris wants to merge codex/wildloop-native-map-providers into main
28 files +1857 -481

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/android/fixtures/native-navigation/NativeMapTest.ktmodified+10-0
Changes to packages/android/fixtures/native-navigation/NativeMapTest.kt
@@ -236,6 +236,16 @@ class NativeMapTest {
236236 assertEquals("Echoing a native region must preserve longitude", before.get().target!!.longitude, after.get().target!!.longitude, 0.000001)
237237 }
238238 evidence("map-controlled-region-after-drag")
239 main {
240 host.configure(props().put("region", JSONObject()
241 .put("center", JSONObject().put("latitude", 47.04).put("longitude", 11.04))
242 .put("span", JSONObject().put("latitudeDelta", 0.004).put("longitudeDelta", 0.004))), overlays()) {}
243 }
244 awaitState("A new controlled region must still move the native camera") {
245 val target = map.cameraPosition.target
246 target != null && kotlin.math.abs(target.latitude - before.get().target!!.latitude) > 0.01 &&
247 kotlin.math.abs(target.longitude - before.get().target!!.longitude) > 0.01
248 }
239249 }
240250
241251 @Test