also looking at this
feat: add Linux and Windows named-window routing
#325
29 files
+2250
-200
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -112,7 +112,7 @@ jobs: | ||
| 112 | 112 | run: | |
| 113 | 113 | # The Pantry .bin shim can print zig version but cannot locate Zig's |
| 114 | 114 | # lib directory during a build. Run the locked package binary itself. |
| 115 | $env:CRAFT_ZIG = Join-Path $env:GITHUB_WORKSPACE 'pantry/ziglang.org/v0.17.0-dev.1963_e00c6c439/bin/zig.exe' | |
| 115 | $env:CRAFT_ZIG = Join-Path $env:GITHUB_WORKSPACE 'pantry/ziglang-org/0.17.0-dev.1963_e00c6c439/bin/zig.exe' | |
| 116 | 116 | if (-not (Test-Path -LiteralPath $env:CRAFT_ZIG)) { throw "Pinned Zig executable missing: $env:CRAFT_ZIG" } |
| 117 | 117 | bun run build:core |
| 118 | 118 | |
| @@ -31,7 +31,7 @@ test('accepts only the locked snapshot by default, even when PATH shadows it', ( | ||
| 31 | 31 | test('Windows uses the pinned Pantry installation instead of its .bin shim', () => { |
| 32 | 32 | const f = fixture() |
| 33 | 33 | const version = pinnedZigVersion(f.root) |
| 34 | const installed = join(f.root, 'pantry/ziglang.org/v0.17.0-dev.1963_e00c6c439/bin/zig.exe') | |
| 34 | const installed = join(f.root, 'pantry/ziglang-org/0.17.0-dev.1963_e00c6c439/bin/zig.exe') | |
| 35 | 35 | expect(pinnedPantryZigPath(f.root, version, f.env, 'win32')).toBeNull() |
| 36 | 36 | mkdirSync(join(installed, '..'), { recursive: true }) |
| 37 | 37 | writeFileSync(installed, '') |
| @@ -11,7 +11,7 @@ export function pinnedZigVersion(root: string): string { | ||
| 11 | 11 | |
| 12 | 12 | export function pinnedPantryZigPath(root: string, expected: string, env: NodeJS.ProcessEnv, hostPlatform: string): string | null { |
| 13 | 13 | if (hostPlatform !== 'win32' || env.CRAFT_ZIG) return null |
| 14 | const installed = join(root, 'pantry', 'ziglang.org', `v${expected.replace('+', '_')}`, 'bin', 'zig.exe') | |
| 14 | const installed = join(root, 'pantry', 'ziglang-org', expected.replace('+', '_'), 'bin', 'zig.exe') | |
| 15 | 15 | return existsSync(installed) ? installed : null |
| 16 | 16 | } |
| 17 | 17 | |