ReviewOS

also looking at this

craft-native/craft

Gate releases on shipped artifact findings

#316
Merged glennmichael123 wants to merge codex/gate-shipped-artifacts into main
11 files +454 -25
scripts/release-workflow.test.tsmodified+18-4
Changes to scripts/release-workflow.test.ts
@@ -19,8 +19,10 @@ const steps = (job: Job) => job.steps?.map(step => step.run ?? '').join('\n') ??
1919test('every publishing path depends on release identity validation', () => {
2020 for (const name of ['pantry', 'npm', 'release-sbom', 'verify-release', 'verify-macos-downloads'])
2121 expect(needs(release.jobs[name])).toContain('validate-release')
22 for (const name of ['npm', 'verify-release', 'verify-macos-downloads'])
22 for (const name of ['verify-release', 'verify-macos-downloads'])
2323 expect(release.jobs[name].if).toBe("${⁠{ !cancelled() && needs.validate-release.result == 'success' }}")
24 expect(release.jobs.npm.if).toBe("${⁠{ !cancelled() && needs.validate-release.result == 'success' && needs.release-sbom.result == 'success' }}")
25 expect(needs(release.jobs.npm)).toContain('release-sbom')
2426})
2527
2628test('registry indexing waits for the final manifest, macOS downloads and attached SBOMs', () => {
@@ -34,16 +36,28 @@ test('registry indexing waits for the final manifest, macOS downloads and attach
3436
3537test('npm publication follows artifact validation, and macOS downloads run on both matching architectures', () => {
3638 const npm = release.jobs.npm.steps!.map(step => step.run ?? '')
37 const verify = npm.indexOf('bun run verify:npm')
39 const verify = npm.indexOf('bun scripts/npm-packages.ts --archive-dir "$RUNNER_TEMP/craft-npm-archives"')
40 const scan = npm.indexOf('bun scripts/scan-release-artifacts.ts npm "$RUNNER_TEMP/craft-npm-archives" "$RUNNER_TEMP/npm-release-scan"')
41 const publish = npm.indexOf('bun scripts/publish-npm-archives.ts "$RUNNER_TEMP/craft-npm-archives"')
3842 expect(verify).toBeGreaterThan(-1)
39 expect(npm.indexOf('pantry publish --npm --access public')).toBeGreaterThan(verify)
43 expect(scan).toBeGreaterThan(verify)
44 expect(publish).toBeGreaterThan(scan)
45 expect(steps(release.jobs.npm)).not.toContain('pantry publish --npm')
46 expect(release.jobs.npm.steps!.find(step => step.name === 'Publish scanned npm archives')?.env?.NODE_AUTH_TOKEN).toBe('${⁠{ secrets.NPM_TOKEN }}')
47 const native = release.jobs.pantry.steps!
48 expect(native.findIndex(step => step.name === 'Scan binaries prepared for publication')).toBeGreaterThan(native.findIndex(step => step.name === 'Notarize macOS binaries'))
49 expect(native.findIndex(step => step.name === 'Publish & Release')).toBeGreaterThan(native.findIndex(step => step.name === 'Scan binaries prepared for publication'))
50 expect(native.find(step => step.name === 'Scan binaries prepared for publication')?.run)
51 .toBe('bun scripts/scan-release-artifacts.ts "$CRAFT_PLATFORM" packages/zig/zig-out "$RUNNER_TEMP/native-release-scan"')
52 expect(native.filter(step => step.uses === './.github/actions/setup-release-scanners')).toHaveLength(1)
53 expect(release.jobs.npm.steps!.filter(step => step.uses === './.github/actions/setup-release-scanners')).toHaveLength(1)
4054 expect(release.jobs['verify-macos-downloads'].strategy?.matrix.platform).toEqual([
4155 { os: 'macos-15', name: 'darwin-arm64' },
4256 { os: 'macos-15-intel', name: 'darwin-x64' },
4357 ])
4458 expect(steps(release.jobs['verify-macos-downloads'])).toContain('scripts/verify-macos-release.ts')
4559 expect(release.jobs['release-sbom'].uses).toBe('./.github/workflows/sbom.yml')
46 expect(release.jobs['release-sbom'].with?.enforce_high).toBe(true)
60 expect(release.jobs['release-sbom'].with?.enforce_high).toBe(false)
4761 expect(needs(release.jobs.pantry)).toContain('release-sbom')
4862 expect(steps(release.jobs.pantry)).toContain('bun install --frozen-lockfile')
4963 expect(steps(release.jobs.npm)).toContain('bun install --frozen-lockfile')