ReviewOS

also looking at this

craft-native/craft

test(ios): verify app termination before local notification delivery

#308
Merged glennmichael123 wants to merge codex/ios-notification-deadline into main
5 files +96 -21
9 days ago

Summary

  • Replace the eight-second local-notification window with a bounded two-minute window supplied by the host harness.
  • Report the earliest delivery deadline before entering the native bridge; delayed callbacks cannot reset it.
  • Assert the app has stopped before that deadline, log the remaining margin, and bound the banner wait to the remaining interval plus delivery grace.
  • Preserve the existing overall UI-test budget plus the scheduled interval, and propagate failed XCUITest exits.

Verification

  • Regression tests execute the actual driver scheduling block, including delayed callbacks, invalid windows and native rejection; the old eight-second implementation fails them.
  • Four focused scheduling tests pass (20 assertions); the full protocol suite passed before the fourth case was added.
  • Pickier, Swift syntax parsing and git diff checks pass.
  • Real shim/runtime simulator E2E is required before merge.

Fixes #307. No production notification API changes and no retries or skipped phases are introduced.

5 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.