ReviewOS

also looking at this

craft-native/craft

fix(ios): preserve specific protocol errors during dispatch

#303
Merged glennmichael123 wants to merge codex/preserve-native-bridge-errors into main
3 files +51 -11
9 days ago

Summary

  • Preserve every declared BridgeError through handler narrowing using the error set itself, then translate implementation aliases and retain the unknown-error fallback.
  • Table-test the full error vocabulary at the mapper and iOS dispatcher boundary.
  • Regress both missing-WebView presenter lookups and carry a real share-handler failure through narrowing and correlated JSON serialization.

Closes #271.

Validation

  • The table-driven test failed before the fix because WindowHandleNotSet became NativeCallFailed; WebView and other explicitly declared variants had the same defect.
  • All 34 bridge-error/request-context unit tests pass after the fix.
  • The complete native suite passes in an isolated checkout using the locked Zig toolchain and CI-pinned first-party dependencies.
  • Pinned Zig format checks and git diff checks pass.

3 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.