ReviewOS

also looking at this

craft-native/craft

fix(release): publish one complete platform manifest

#293
Merged glennmichael123 wants to merge codex/complete-release-manifest into main
4 files +145 -2
scripts/release-manifest.test.tsadded+63-0
Changes to scripts/release-manifest.test.ts
@@ -0,0 +1,63 @@
1import { expect, test } from 'bun:test'
2import { mkdtempSync, rmSync, writeFileSync } from 'node:fs'
3import { tmpdir } from 'node:os'
4import { join } from 'node:path'
5import { createReleaseManifest, verifyReleaseManifest } from './release-manifest'
6
7const identity = { repository: 'craft-native/craft', tag: 'v0.0.93', commit: 'a'.repeat(40) }
8const names = ['craft-darwin-arm64.zip', 'craft-darwin-x64.zip', 'craft-linux-x64.zip', 'craft-windows-x64.zip']
9
10function withArchives(check: (dir: string) => void): void {
11 const dir = mkdtempSync(join(tmpdir(), 'craft-manifest-'))
12 try {
13 for (const name of names) writeFileSync(join(dir, name), `bytes for ${name}`)
14 check(dir)
15 }
16 finally {
17 rmSync(dir, { recursive: true, force: true })
18 }
19}
20
21test('includes every platform and additional future archives with exact byte hashes', () => {
22 withArchives((dir) => {
23 writeFileSync(join(dir, 'craft-linux-arm64.zip'), 'abc')
24 const manifest = createReleaseManifest(identity, dir)
25 expect(manifest.assets).toHaveLength(5)
26 expect(manifest.assets.find(asset => asset.name === 'craft-linux-arm64.zip')).toEqual({ name: 'craft-linux-arm64.zip', size: 3, sha256: 'ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad' })
27 expect(() => verifyReleaseManifest(manifest, manifest)).not.toThrow()
28 })
29})
30
31test('rejects the macOS-only manifest shape that shipped in v0.0.92', () => {
32 withArchives((dir) => {
33 const expected = createReleaseManifest(identity, dir)
34 expect(() => verifyReleaseManifest({ ...expected, assets: expected.assets.slice(0, 2) }, expected)).toThrow('asset set mismatch')
35 })
36})
37
38test('requires Windows and rejects empty archives', () => {
39 withArchives((dir) => {
40 rmSync(join(dir, 'craft-windows-x64.zip'))
41 expect(() => createReleaseManifest(identity, dir)).toThrow('craft-windows-x64.zip')
42 writeFileSync(join(dir, 'craft-windows-x64.zip'), '')
43 expect(() => createReleaseManifest(identity, dir)).toThrow('empty')
44 })
45})
46
47test('rejects changed bytes, duplicate assets, unexpected names and stale identity', () => {
48 withArchives((dir) => {
49 const expected = createReleaseManifest(identity, dir)
50 for (const key of ['schemaVersion', 'repository', 'tag', 'commit'])
51 expect(() => verifyReleaseManifest({ ...expected, [key]: 'wrong' }, expected)).toThrow('mismatch')
52 const duplicate = structuredClone(expected)
53 duplicate.assets[1] = duplicate.assets[0]
54 expect(() => verifyReleaseManifest(duplicate, expected)).toThrow('duplicate')
55 for (const changed of [{ name: 'craft-unknown.zip' }, { size: 1 }, { sha256: '0'.repeat(64) }]) {
56 const manifest = structuredClone(expected)
57 Object.assign(manifest.assets[0], changed)
58 expect(() => verifyReleaseManifest(manifest, expected)).toThrow()
59 }
60 writeFileSync(join(dir, names[0]), 'tampered')
61 expect(() => verifyReleaseManifest(expected, createReleaseManifest(identity, dir))).toThrow('SHA-256 mismatch')
62 })
63})