ReviewOS

also looking at this

craft-native/craft

feat(ios): tell the page about a notification that arrives while the app is open

#259
Merged glennmichael123 wants to merge feat/ios-notification-received into main
11 files +410 -58

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/typescript/types/craft.d.tsmodified+6-0
Changes to packages/typescript/types/craft.d.ts
@@ -1495,6 +1495,11 @@ export interface CraftNotificationResponseEvent extends CustomEvent {
14951495 detail: Record<string, any>;
14961496}
14971497
1498/** A notification that arrived while the app was open, in the same shape as a tap. iOS. */
1499export interface CraftNotificationReceivedEvent extends CustomEvent {
1500 detail: Record<string, any>;
1501}
1502
14981503export interface CraftWatchUserInfoEvent extends CustomEvent {
14991504 detail: Record<string, any>;
15001505}
@@ -1546,6 +1551,7 @@ declare global {
15461551 craftNetworkChange: CraftNetworkChangeEvent;
15471552 craftPushToken: CraftPushTokenEvent;
15481553 craftNotificationResponse: CraftNotificationResponseEvent;
1554 craftNotificationReceived: CraftNotificationReceivedEvent;
15491555 craftWatchMessage: CraftWatchMessageEvent;
15501556 craftWatchReachability: CraftWatchReachabilityEvent;
15511557 craftWatchContext: CraftWatchContextEvent;