ReviewOS

also looking at this

craft-native/craft

fix(android): resolve share() with whether the person picked an app

#210
Merged glennmichael123 wants to merge fix/android-share-outcome into main
12 files +399 -56
packages/zig/src/android_dispatch.zigmodified+4-2
Changes to packages/zig/src/android_dispatch.zig
@@ -283,7 +283,7 @@ const natives = [_]jni.JNINativeMethod{
283283 },
284284 .{
285285 .name = "nativeShare",
286 .signature = "(Landroid/app/Activity;Ljava/lang/String;Ljava/lang/String;)Z",
286 .signature = "(Landroid/app/Activity;Ljava/lang/String;Ljava/lang/String;Landroid/content/IntentSender;I)Z",
287287 .fnPtr = @ptrCast(&nativeShare),
288288 },
289289 .{
@@ -879,6 +879,8 @@ fn nativeShare(
879879 activity: jni.jobject,
880880 text: jni.jstring,
881881 title: jni.jstring,
882 chosen: jni.jobject,
883 request_code: jni.jint,
882884) callconv(.c) jni.jboolean {
883885 const j = Jni.init(env);
884886 var arena = std.heap.ArenaAllocator.init(backing);
@@ -888,7 +890,7 @@ fn nativeShare(
888890 const body = j.stringToUtf8(allocator, text) catch |err| return fellThrough("share", err, jni.JNI_FALSE);
889891 const subject = j.stringToUtf8(allocator, title) catch |err| return fellThrough("share", err, jni.JNI_FALSE);
890892
891 intents.share(j, allocator, activity, body, subject) catch |err| {
893 intents.share(j, allocator, activity, body, subject, chosen, request_code) catch |err| {
892894 std.log.warn("craft: share fell through to the shim ({s})", .{@errorName(err)});
893895 return jni.JNI_FALSE;
894896 };