ReviewOS

also looking at this

craft-native/craft

feat(android): the first listener shim, and network monitoring on it — 61 → 59

#183
Merged glennmichael123 wants to merge feat/android-network-watch into main
5 files +246 -13
packages/android/templates/CraftBridge.kt.templatemodified+8-0
Changes to packages/android/templates/CraftBridge.kt.template
@@ -1962,6 +1962,12 @@ class CraftBridge(
19621962
19631963 @JavascriptInterface
19641964 fun startNetworkMonitoring() {
1965 // The callback object is CraftNative's, because JNI cannot subclass
1966 // an abstract Java class — what Zig owns is what happens when it
1967 // fires. Returning here keeps this file's networkCallback null, which
1968 // is why stopNetworkMonitoring has to reach the same way.
1969 if (CraftNative.startNetworkMonitoring(activity)) return
1970
19651971 val connectivityManager = activity.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
19661972
19671973 networkCallback = object : ConnectivityManager.NetworkCallback() {
@@ -1987,6 +1993,8 @@ class CraftBridge(
19871993
19881994 @JavascriptInterface
19891995 fun stopNetworkMonitoring() {
1996 if (CraftNative.stopNetworkMonitoring(activity)) return
1997
19901998 val connectivityManager = activity.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
19911999 networkCallback?.let {
19922000 connectivityManager.unregisterNetworkCallback(it)