also looking at this
feat(ios): AR moves to Zig — ratchet 18 -> 13
#126
5 files
+1480
-10
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -858,9 +858,13 @@ fn addViewToKeyWindow(view: Id) void { | ||
| 858 | 858 | return; |
| 859 | 859 | }; |
| 860 | 860 | |
| 861 | // No retain here. `alloc`/`initWithFrame:` already gave this frame the one | |
| 862 | // reference `ar_view` owns and `stopAR` releases; `addSubview:` gives the | |
| 863 | // window a second one that `removeFromSuperview` drops. A third would | |
| 864 | // outlive both, and it would take the whole SceneKit graph with it on every | |
| 865 | // start/stop cycle. | |
| 861 | 866 | const sel_add = objc.sel_registerName("addSubview:") orelse return; |
| 862 | 867 | objc.msgSendVoid1(window, sel_add, view); |
| 863 | retain(view); | |
| 864 | 868 | } |
| 865 | 869 | |
| 866 | 870 | /// The seven numbers `getARPlanes` reads off one anchor. |