ReviewOS

also looking at this

craft-native/craft

feat(ios): AR moves to Zig — ratchet 18 -> 13

#126
Merged glennmichael123 wants to merge feat/ios-ar into main
5 files +1480 -10

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/zig/src/bridge_mobile_ar.zigmodified+5-1
Changes to packages/zig/src/bridge_mobile_ar.zig
@@ -858,9 +858,13 @@ fn addViewToKeyWindow(view: Id) void {
858858 return;
859859 };
860860
861 // No retain here. `alloc`/`initWithFrame:` already gave this frame the one
862 // reference `ar_view` owns and `stopAR` releases; `addSubview:` gives the
863 // window a second one that `removeFromSuperview` drops. A third would
864 // outlive both, and it would take the whole SceneKit graph with it on every
865 // start/stop cycle.
861866 const sel_add = objc.sel_registerName("addSubview:") orelse return;
862867 objc.msgSendVoid1(window, sel_add, view);
863 retain(view);
864868}
865869
866870/// The seven numbers `getARPlanes` reads off one anchor.