ReviewOS

also looking at this

craft-native/craft

feat(ios): scheduleNotification — the deferral that expired on its own, ratchet 26 → 25

#110
Merged glennmichael123 wants to merge feat/ios-schedule-notification into main
6 files +922 -37
.github/workflows/ci.ymlmodified+29-1
Changes to .github/workflows/ci.yml
@@ -109,6 +109,34 @@ jobs:
109109 working-directory: packages/typescript
110110 run: bun run build
111111
112 # `packages/ios` had a test suite that nothing ran. That is how its
113 # generator kept a defect nobody saw: `init()` read `CRAFT_IOS_RUNTIME`
114 # straight from the environment, so the suite passed 12/12 in a clean shell
115 # and 8/12 in a developer's, and CI never had an opinion either way.
116 ios-builder:
117 runs-on: ubuntu-latest
118
119 steps:
120 - uses: actions/checkout@v6
121
122 - name: Setup Pantry (provides Bun, Zig, etc.)
123 uses: pantry-pm/pantry/packages/action@235036fa0f48bae99b2293df5a3dc35c809b1777 # pinned: last SHA whose bundled typescript resolves on linux-x64
124
125 - name: Install dependencies
126 run: bun install
127
128 # Unset deliberately. The suite must not depend on it, and this is the
129 # job that would notice if it started to again.
130 - name: Test iOS builder
131 working-directory: packages/ios
132 run: bun test
133 env:
134 CRAFT_IOS_RUNTIME: ''
135
136 - name: Build iOS builder
137 working-directory: packages/ios
138 run: bun run build
139
112140 create-craft:
113141 runs-on: ubuntu-latest
114142
@@ -219,7 +247,7 @@ jobs:
219247 run: bun run verify
220248
221249 publish-commit:
222 needs: [zig-core, typescript-sdk, create-craft, ts-maps, lint, integration]
250 needs: [zig-core, typescript-sdk, ios-builder, create-craft, ts-maps, lint, integration]
223251 runs-on: ubuntu-latest
224252
225253 steps: