ReviewOS

craft-native/craft

Mirror shake gesture boolean validation in the Zig iOS configuration reader

#444
Open chris opened this 2 hours ago ·
2 hours ago

Craft 0.0.427 source CI fails its independent Swift/Zig configuration conformance check: https://github.com/craft-native/craft/actions/runs/41500249674/job/125465579922. The Linux suite reports one failure: Swift CraftConfig validates enableShakeGesture, but the Zig reader does not list that stored key. The preceding shake-gesture feature added the SDK, generator and Swift option while leaving Zig validation behind.

This is also a behavior mismatch: a configuration with enableClipboard=true and a wrongly typed enableShakeGesture is rejected by Swift but still grants clipboard in Zig. A new actual Zig parse regression reproduces that discrepancy (expected zero enabled capabilities, observed one).

Mirror the non-capability boolean key, preserve missing/null/default semantics, and generalize the complete-config fixture's boolean placeholders. Verify real parser cases for true/false/null and wrong scalar/container types, the existing independent Swift/Zig key conformance suite, and default/opt-in builder serialization with its independent motion permission compilation. Keep the existing release gates intact.

Blocks publication and public consumption of the scroll-target correction in https://github.com/craft-native/craft/issues/443; related enterprise native acceptance: https://github.com/stacksjs/hq.training/issues/318.

Sign in to comment on this issue.