ReviewOS

craft-native/craft

ci: zig-core runs the first-party Zig dependencies step twice

#323
Closed glennmichael123 opened this 9 days ago ·
9 days ago

.github/workflows/ci.yml invokes ./.github/actions/first-party-zig-deps twice inside the zig-core job:

  • line 56, before Build Zig core
  • line 68, after Verify built native CLI startup and before Test Zig core

The second run is a no-op — the action returns early when each checkout is already at the SHA in pins.env ("$repo already at $sha") — so this is waste rather than a defect, on both matrix legs of every pull request and push.

It looks like an artifact of #316 and #317 landing back to back: #317 inserted the native-startup step into that region, and the dependency step ended up on both sides of it.

Removing one is a three-line deletion. Worth confirming which position is load-bearing first: Build Zig core needs the sibling checkouts, so the earlier one is the one to keep.

Noticed while working on an unrelated iOS test fix; filing rather than folding it into that pull request.

Sign in to comment on this issue.