ReviewOS

craft-native/craft

Include the MIT license in every published npm tarball

#277
Closed glennmichael123 opened this 9 days ago ·
9 days ago

Problem

A release dry-run from current main shows that only the craft-native tarball contains LICENSE.md. The following published packages declare MIT in package.json but ship no LICENSE or LICENSE.md file:

This makes the legal text unavailable to offline consumers inspecting the installed package or tarball.

Reproduction

  1. Build the packages.
  2. Run bun pm pack from each package directory.
  3. Inspect each archive with tar -tzf.

Only craft-native includes package/LICENSE.md.

Expected

Every public npm tarball includes the repository MIT license text, with a packaging verification that fails if it is absent.

Suggested scope

  • Include LICENSE.md in each public package without duplicating divergent license text.
  • Extend scripts/verify-packages.ts or a pack-level test so future public packages cannot omit it.
  • Keep package contents otherwise unchanged.

Discovered during the post-merge release audit for #254, #242, and #220.

9 days ago

Correction after inspecting the actual npm registry tarballs: all eight published 0.0.92 packages contain package/LICENSE.md, and each license file has the same SHA-256 as the repository license (c15be330cd4732525896e24adf6e4d029ba9ff641670b5d4998f7f437f77d5bb). The release log confirms Pantry copies the root license into secondary packages before publishing.

The original report conflated local bun pm pack output with Pantry-published artifacts. Local pack parity could be improved, but there is no missing-license defect in the current published release, so this is not a release blocker. Closing the inaccurate published-package report.

Sign in to comment on this issue.